Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix-dependency-handling #89

Merged
merged 19 commits into from
Sep 6, 2024
Merged

Fix-dependency-handling #89

merged 19 commits into from
Sep 6, 2024

Conversation

ewuerger
Copy link
Member

@ewuerger ewuerger commented Jul 31, 2024 •
edited
Loading

@ewuerger ewuerger marked this pull request as ready for review August 1, 2024 15:59
@ewuerger ewuerger requested a review from micha91 August 8, 2024 07:41
@ewuerger ewuerger self-assigned this Aug 8, 2024
@ewuerger ewuerger added the enhancement New feature or request label Aug 8, 2024
micha91
micha91 requested changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@micha91 micha91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor stuff. In addition, I would highly recommend to be more strict with some kinds of exception. If we for example fail to create new Work Items in Polarion the pipeline should imo directly fail

capella2polarion/connectors/polarion_repo.py Outdated Show resolved Hide resolved
capella2polarion/connectors/polarion_worker.py Outdated Show resolved Hide resolved
capella2polarion/connectors/polarion_worker.py Outdated Show resolved Hide resolved
capella2polarion/connectors/polarion_worker.py Outdated Show resolved Hide resolved
capella2polarion/connectors/polarion_worker.py Outdated Show resolved Hide resolved
capella2polarion/converters/element_converter.py Outdated Show resolved Hide resolved
capella2polarion/converters/link_converter.py Outdated Show resolved Hide resolved
@ewuerger ewuerger force-pushed the fix-dependency-handling branch 3 times, most recently from a0129d3 to 224b339 Compare August 26, 2024 12:46
@ewuerger ewuerger requested a review from micha91 August 26, 2024 12:58
micha91
micha91 requested changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@micha91 micha91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things

capella2polarion/connectors/polarion_repo.py Outdated Show resolved Hide resolved
capella2polarion/connectors/polarion_worker.py Outdated Show resolved Hide resolved
capella2polarion/connectors/polarion_worker.py Outdated Show resolved Hide resolved
capella2polarion/connectors/polarion_worker.py Outdated Show resolved Hide resolved
capella2polarion/connectors/polarion_worker.py Outdated Show resolved Hide resolved
capella2polarion/converters/document_config.py Outdated Show resolved Hide resolved
micha91
micha91 requested changes Aug 27, 2024
View reviewed changes
capella2polarion/connectors/polarion_worker.py Outdated Show resolved Hide resolved
capella2polarion/connectors/polarion_worker.py Outdated Show resolved Hide resolved
capella2polarion/converters/document_config.py Outdated Show resolved Hide resolved
@ewuerger ewuerger force-pushed the fix-dependency-handling branch from 72697a6 to 8f06da9 Compare August 29, 2024 09:07
ewuerger and others added 18 commits September 6, 2024 14:16
@ewuerger
ci: Update hooks and add dependencies to mypy hook
946af3a
@ewuerger
ci: Please mypy hooks
b14eb5a
@ewuerger
fix: Make tests green again
8f85f46
@ewuerger
fix: Log work items without id during link creation
62c2a30
@ewuerger
ci: Fix some mypy errors
fcfe757
@ewuerger
ci: Fix type annotations
a5744e6
@ewuerger
ci: Update pre-commit
2ccc1c3
@ewuerger
fix: Apply suggestions from code review
9754321
@ewuerger
fix: Attachment old checksum generation
190746e
@ewuerger
test: Remove overwriting of checksums
e1f788f
@ewuerger @micha91
refactor: Apply suggestions from code review
721defb 
Co-authored-by: micha91 <[email protected]>
@ewuerger
fix: Remove type annotation
38efc8c
@ewuerger
fix: Raise a ValueError when a work item without ID is found
ab19284
@ewuerger
fix: Just import polarion_rest_api_client
777aeab 
This needs [polarion-open-rest-api-client #47](DSD-DBS/polarion-rest-api-client#47).
@ewuerger
revert: Stop checking stuff that never happen
a2bbabd 
Just assert the state.
@micha91 @ewuerger
build: Update polarion-rest-api-client
aa370e8
@ewuerger
ci: Fix pre commit hooks
8dc0ba3
@ewuerger
fix: Remove debugging logs from dependencies
b0cd0d5
@ewuerger ewuerger force-pushed the fix-dependency-handling branch from 8f06da9 to 637e9d0 Compare September 6, 2024 13:18
@ewuerger ewuerger force-pushed the fix-dependency-handling branch from 637e9d0 to dce72af Compare September 6, 2024 13:21
@ewuerger ewuerger requested a review from micha91 September 6, 2024 13:22
@ewuerger ewuerger merged commit 64b8c0f into main Sep 6, 2024
8 checks passed
@ewuerger ewuerger deleted the fix-dependency-handling branch September 6, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micha91 micha91 Awaiting requested review from micha91

Assignees

@ewuerger ewuerger

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewuerger @micha91